feat(dataframe): add V2 variable query editor under feature toggle #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 12, 2025 07:59
…s/Gokudharan/split-variable-quey-editor-into-v1-v2
added 4 commits
September 18, 2025 12:59
…s/Gokudharan/split-variable-quey-editor-into-v1-v2
…s/Gokudharan/split-variable-quey-editor-into-v1-v2
Base automatically changed from
users/Gokuldharan/split-v1-and-v2-components
to
main
September 30, 2025 07:15
added 2 commits
September 30, 2025 07:33
gokuldharan-ni
requested review from
cameronwaterman,
hemkumarrao-ni and
ushakanagaraj-ni
as code owners
kartheeswaran-ni
approved these changes
Oct 5, 2025
| import { DataFrameVariableQueryEditorV1 } from './v1/DataFrameVariableQueryEditorV1'; | ||
| import { DataFrameVariableQueryEditorV2 } from './v2/DataFrameVariableQueryEditorV2'; | ||
|
|
||
| export function DataFrameVariableQueryEditorWrapper(props: Props) { |
There was a problem hiding this comment.
nit: src/datasources/data-frame/components/DataFrameQueryEditorWrapper.tsx uses arrow function syntax. can we follow the same here to maintain consistency?
There was a problem hiding this comment.
Please add tests for this file.
|
@gokuldharan-ni , When closing the PR, could we add a comment explaining the reason for closure so other reviewers can understand the context? |
I have moved the changes to a different branch and created a PR for the other branch, so I abandoned this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Task 3262819: Move the legacy variable query editor into v1 and add a new v2 variable query editor under feature toggle
This PR moves the legacy variable query editor into v1 and adds a v2 variable query editor under feature toggle.
👩💻 Implementation
🧪 Testing
Added unit tests for the introduced functionalities
✅ Checklist